WIP: Allow deployment on incus #17
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "tc424/core-infra:incus-test"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Looks sensible. Only comment I'd have is perhaps renaming the "image_names" module to "provider_metadata", to make it easy to reuse for other provider-specific stuff (like DNS servers?).
If adding more stuff, it might also be less annoying to read if it had a variable for "provider", rather than returning all of the data and doing the filter on use.
Yeah, I was thinking about renaming it. The other option that occurred to me was just to inline the per-provider data into the modules for each provider using locals? I assume that's possible in tf ..
You mean put it in the "scaleway_instance" module etc. ? That'd work, though it might make it easy to forget to add equivs for other providers (if we care about that).
c62d8a0da8to7f73cdeade4653aac17bto035f313b8d09ef2e3cdfto08356bc8da08356bc8dato9f651f78909f651f7890to0fc5345db2View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.